add ignoreNullValues for AWS CloudWatch Scaler #5635
+886
−275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
robpickerill
force-pushed
the
cloudwatch-error-when-empty-metrics
branch
from
13c0fec
to
53ea3fd
Compare
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
robpickerill
force-pushed
the
cloudwatch-error-when-empty-metrics
branch
3 times, most recently
from
495c201
to
8e41311
Compare
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
robpickerill
force-pushed
the
cloudwatch-error-when-empty-metrics
branch
from
584eba6
to
b0d4e84
Compare
JorTurFer
reviewed
Mar 30, 2024
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
7 tasks
robpickerill
changed the title
|
I added end to end tests here for both minMetricValue and errorWhenNullValues to cover off both scenarios. I need to tidy them up a little, which ill do over the next few days. |
robpickerill
force-pushed
the
cloudwatch-error-when-empty-metrics
branch
2 times, most recently
from
53fac56
to
0ef98c5
Compare
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
robpickerill
force-pushed
the
cloudwatch-error-when-empty-metrics
branch
from
0ef98c5
to
0b61f97
Compare
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
robpickerill
force-pushed
the
cloudwatch-error-when-empty-metrics
branch
from
68a1c71
to
0dc9b77
Compare
robpickerill
commented
Apr 4, 2024
...calers/aws/aws_cloudwatch_min_value_null_values/aws_cloudwatch_min_value_null_values_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
robpickerill
changed the title
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
robpickerill
commented
Apr 13, 2024
…cloudwatch_ignore_null_values_false_test.go Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
JorTurFer
reviewed
May 4, 2024
.../aws/aws_cloudwatch_ignore_null_values_false/aws_cloudwatch_ignore_null_values_false_test.go
Outdated
Show resolved
Hide resolved
.../aws/aws_cloudwatch_ignore_null_values_false/aws_cloudwatch_ignore_null_values_false_test.go
Outdated
Show resolved
Hide resolved
tests/scalers/aws/aws_cloudwatch_min_metric_value/aws_cloudwatch_min_metric_value_test.go
Outdated
Show resolved
Hide resolved
…tricValue Signed-off-by: robpickerill <r.pickerill@gmail.com>
|
@robpickerill any updates here please? |
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Good for review, all comments are addressed |
robpickerill
force-pushed
the
cloudwatch-error-when-empty-metrics
branch
from
a67d1c0
to
410c10f
Compare
Signed-off-by: robpickerill <r.pickerill@gmail.com>
robpickerill
force-pushed
the
cloudwatch-error-when-empty-metrics
branch
from
410c10f
to
9374c26
Compare
JorTurFer
reviewed
May 21, 2024
tests/scalers/aws/aws_cloudwatch_min_metric_value/aws_cloudwatch_min_metric_value_test.go
Outdated
Show resolved
Hide resolved
|
/run-e2e aws |
…ch_min_metric_value_test.go fix invalid check Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
|
/run-e2e aws |
|
/run-e2e aws |
|
@robpickerill do we have any update on this, please? |
|
I was discussing with Jorge on slack to get the e2e tests re-ran, as the failures were upstream issues: https://kubernetes.slack.com/archives/C01JGDP8MB8/p1717129850310929?thread_ts=1715943304.582119&cid=C01JGDP8MB8 However, since then the changes for the validation have gone in, so let me fix up the conflicts here over the weekend, and then let's get e2e passing again on this branch |
|
Thanks! |
Signed-off-by: robpickerill <r.pickerill@gmail.com>
robpickerill
force-pushed
the
cloudwatch-error-when-empty-metrics
branch
from
731d45c
to
2e76a9b
Compare
|
Fixed conflicts, this needs another e2e test run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for erroring the AWS Cloudwatch Scaler when the GetMetricData call returns an empty set of metrics, resulting in no scale-changing behaviour when no custom metrics are available during the Cloudwatch query window.
Checklist
Fixes #5352
Relates to: