fix(scaledobject): reconcile hpa on label or annotations change #5482
Conversation
chubchubsancho
force-pushed
the
fix/scaledobject/reconcile_on_annotations_change
branch
2 times, most recently
from
ee89f8b
to
9c3703e
Compare
Signed-off-by: Grégory SANCHEZ <gregory.sanchez@icloud.com>
chubchubsancho
force-pushed
the
fix/scaledobject/reconcile_on_annotations_change
branch
from
9c3703e
to
731512f
Compare
Co-authored-by: Jean-Yves CAMIER <jycamier@gmail.com> Signed-off-by: Grégory SANCHEZ <gregory.sanchez@icloud.com>
There was a problem hiding this comment.
Looking good! only a small nit inline.
Although it's okey, I want to know @zroubalik's thoughts because maybe we weren't checking annotations and labels for any reason I'm missing
| @@ -132,6 +132,8 @@ func (r *ScaledObjectReconciler) SetupWithManager(mgr ctrl.Manager, options cont | |||
| kedacontrollerutil.PausedReplicasPredicate{}, | |||
| kedacontrollerutil.ScaleObjectReadyConditionPredicate{}, | |||
| predicate.GenerationChangedPredicate{}, | |||
| predicate.LabelChangedPredicate{}, | |||
| predicate.AnnotationChangedPredicate{}, | |||
There was a problem hiding this comment.
Adding this predicate we don't need
kedacontrollerutil.PausedPredicate{},
kedacontrollerutil.PausedReplicasPredicate{},as both are allowing changes on annotations.
There was a problem hiding this comment.
The reason for not reconciling on labels/annotations was to limit the number of reconciliations in total and subsequent re-creation of scale loops. I am not sure we should change the behavior this way. Maybe adding specific fields for annotations/labels in spec.advanced.hpconfig.. ? Not sure though
|
@chubchubsancho Any update on this PR? |
@tomkerkhove sorry i have not so much time past week to rework on this PR. I need to take a look at @zroubalik approach. |
no worries |
Provide a description of what has been changed
HPA need to be reconcile on scaledObject annotations or labels update
Checklist
Fixes #
#5468