Added support for synchrous Reka using the OpenAI SDK format. #624
Conversation
dosubot
bot
added
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested.
- Reviewed the entire pull request up to b1f4f1e
- Looked at
293lines of code in7files - Took 1 minute and 54 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of85%.
1. /instructor/client_reka.py:31:
- Assessed confidence :
66% - Comment:
Consider allowing more modes if the Reka-specific JSON mode testing involves other modes or if future expansions are planned. Currently, onlyMode.MD_JSONis allowed, which might be too restrictive. - Reasoning:
The PR description mentions that a Reka-specific JSON mode is being tested, but the code only allows forMode.MD_JSON. This could be a limitation if other modes are intended to be supported in the future or if the testing involves other modes.
Workflow ID: wflow_CLfriM6wLxeIeIy2
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.
| ) -> instructor.Instructor: ... | ||
|
|
||
|
|
||
| def from_reka(api_key: Optional[str] =None, |
There was a problem hiding this comment.
Please add an assertion or check to prevent the use of async methods with Reka since async support is not yet implemented. This will help avoid runtime errors if such methods are attempted to be used.
| @@ -0,0 +1,46 @@ | |||
| # Structured Outputs using Reka | |||
There was a problem hiding this comment.
Please update the mkdocs.yml file to include the new reka.md file in the site navigation. This ensures that the documentation is accessible and visible in the generated site.
| temperature=0, | ||
| ) | ||
|
|
||
| print(user_info.name) |
There was a problem hiding this comment.
The variable user_info is not defined in the example code. You should replace user_info with resp to match the variable that holds the response from the Reka client.
| print(user_info.name) | |
| print(resp.name) |
|
|
||
| print(user_info.name) | ||
| #> John Doe | ||
| print(user_info.age) |
There was a problem hiding this comment.
The variable user_info is not defined in the example code. You should replace user_info with resp to match the variable that holds the response from the Reka client.
| print(user_info.age) | |
| print(resp.age) |
| pip install instructor reka-api pydantic | ||
| ``` | ||
|
|
||
| ``` |
|
|
||
| def reka_chat_wrapper(default_model, **kwargs): | ||
| model = kwargs.pop('model',default_model) | ||
| kwargs['model_name']=model |
Will be adding async and am testing a Reka specific json mode
Summary:
This PR introduces support for the Reka AI model in the Instructor library, including a new client, example usage, test case, and documentation.
Key points:
RekaClientandfrom_rekafunction ininstructormodule.client.pyandutils.pyto support Reka client.test_new_client.py.reka.py.reka.md.Generated with ❤️ by ellipsis.dev