New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client,function_calls,process_response,test_new_client): enhance create method to handle multiple responses #578
base: main
Are you sure you want to change the base?
Conversation
Deploying instructor with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me!
- Reviewed the entire pull request up to bfa4ca1
- Looked at
364
lines of code in4
files - Took 1 minute and 32 seconds to review
More info
- Skipped
0
files when reviewing. - Skipped posting
4
additional comments because they didn't meet confidence threshold of85%
.
1. instructor/client.py:65
:
- Assessed confidence :
10%
- Comment:
The changes in this file look good. The support for multiple responses (n > 1) has been added correctly in the create method of both Instructor and AsyncInstructor classes. The code is clear and follows the best practices. - Reasoning:
The PR author has added support for multiple responses (n > 1) in the create method of the Instructor and AsyncInstructor classes. The changes seem to be logically correct and follow the best practices. The author has also updated the tests to cover the new functionality.
2. instructor/function_calls.py:76
:
- Assessed confidence :
10%
- Comment:
The changes in this file look good. The from_response method in the OpenAISchema class has been updated correctly to handle multiple responses. The code is clear and follows the best practices. - Reasoning:
The PR author has updated the from_response method in the OpenAISchema class to handle multiple responses. The changes seem to be logically correct and follow the best practices.
3. instructor/process_response.py:153
:
- Assessed confidence :
10%
- Comment:
The changes in this file look good. The process_response and process_response_async methods have been updated correctly to handle multiple responses. The code is clear and follows the best practices. - Reasoning:
The PR author has updated the process_response and process_response_async methods in the process_response.py file to handle multiple responses. The changes seem to be logically correct and follow the best practices.
4. tests/test_new_client.py:53
:
- Assessed confidence :
10%
- Comment:
The changes in this file look good. The tests have been updated correctly to cover the new functionality of handling multiple responses. The code is clear and follows the best practices. - Reasoning:
The PR author has updated the tests to cover the new functionality of handling multiple responses. The changes seem to be logically correct and follow the best practices.
Workflow ID: wflow_wIPhyK9XK3e85BBb
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
@ellipsis-dev can you fix the merge conflicts |
Could you please specify which files have conflicts and what the conflicts are? This will help me resolve the merge conflicts more effectively. Thank you. Responding to this comment by @jxnl. For more information about Ellipsis, check the documentation. |
Summary:
This PR enhances the
create
method to handle multiple responses from the OpenAI API, updates various methods infunction_calls.py
andprocess_response.py
to handle multiple responses, and includes a test for multiple responses intest_new_client.py
.Key points:
create
method inclient.py
to handle multiple responses.handle_kwargs
method inclient.py
to includen
parameter in kwargs.function_calls.py
to handle multiple responses inparse_functions
,parse_tools
, andparse_json
methods.process_response.py
to attach raw response to each model in case of IterableBase response model.test_new_client.py
to include a test for multiple responses.Generated with ❤️ by ellipsis.dev