refactor(cache): remove deref
impl on Cache
type
#4671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Currently
Cache
is a type having inner value asMokaCache
.There's a deref impl on this type which returns the inner
MokaCache
. We should instead have custom methods onCache
which calls theMokaCache
methods instead of deref doing the job. There's already custom methods available onCache
. This PR refactors it to invoke these methods instead of calling it on the deref ofCache
.Additional Changes
Motivation and Context
How did you test it?
Basic sanity tests should suffice
Checklist
cargo +nightly fmt --all
cargo clippy