Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): handle connector authentication technical failures and skip confirm in authorize flow only when authentication_type is not challenge #4667

Merged
merged 1 commit into from
May 20, 2024

Conversation

sai-harsha-vardhan
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

handle connector authentication technical failures and skip confirm in authorize flow only when authentication_type is not challenge

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sai-harsha-vardhan sai-harsha-vardhan added A-core Area: Core flows C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 17, 2024
@sai-harsha-vardhan sai-harsha-vardhan added this to the May 2024 Release milestone May 17, 2024
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this May 17, 2024
@sai-harsha-vardhan sai-harsha-vardhan requested a review from a team as a code owner May 17, 2024 07:54
@likhinbopanna likhinbopanna added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit 842728e May 20, 2024
12 of 13 checks passed
@likhinbopanna likhinbopanna deleted the fix-connector-4xx-in-external-3ds-flow branch May 20, 2024 13:53
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants