Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use git diff to add M-database-changes label for pr that contains migrations and schema changes #4625

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

ci: use git diff to add M-database-changes label for pr that contains migrations and schema changes #4625

wants to merge 38 commits into from

Conversation

ShankarSinghC
Copy link
Contributor

@ShankarSinghC ShankarSinghC commented May 13, 2024 •
edited

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This ps uses git diff to add M-database-changes label for pr that contains migrations and schema changes.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

We can see that M-database-changes was added for on of the below commits which contained migration changes.
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@ShankarSinghC ShankarSinghC added the A-CI-CD Area: Continuous Integration/Deployment label May 13, 2024
@ShankarSinghC ShankarSinghC self-assigned this May 13, 2024
@ShankarSinghC ShankarSinghC requested a review from a team as a code owner May 13, 2024 07:00
@ShankarSinghC ShankarSinghC requested a review from a team as a code owner May 13, 2024 07:01
@github-actions github-actions bot added the M-database-changes Metadata: This PR involves database schema changes label May 13, 2024
@ShankarSinghC ShankarSinghC linked an issue May 13, 2024 that may be closed by this pull request
ci: use git diff to add M-database-changes label for pr that contains migrations and schema changes #4627
Open
@ShankarSinghC ShankarSinghC removed the M-database-changes Metadata: This PR involves database schema changes label May 13, 2024
@ShankarSinghC ShankarSinghC removed the request for review from a team May 13, 2024 07:28
@github-actions github-actions bot added the M-database-changes Metadata: This PR involves database schema changes label May 13, 2024
@ShankarSinghC ShankarSinghC removed the M-database-changes Metadata: This PR involves database schema changes label May 20, 2024
@github-actions github-actions bot added the M-database-changes Metadata: This PR involves database schema changes label May 20, 2024
@ShankarSinghC ShankarSinghC removed the M-database-changes Metadata: This PR involves database schema changes label May 20, 2024
@github-actions github-actions bot added the M-database-changes Metadata: This PR involves database schema changes label May 20, 2024
@ShankarSinghC ShankarSinghC removed the M-database-changes Metadata: This PR involves database schema changes label May 20, 2024
@github-actions github-actions bot added the M-database-changes Metadata: This PR involves database schema changes label May 20, 2024
@ShankarSinghC ShankarSinghC removed the M-database-changes Metadata: This PR involves database schema changes label May 20, 2024
@github-actions github-actions bot added the M-database-changes Metadata: This PR involves database schema changes label May 20, 2024
@ShankarSinghC ShankarSinghC removed the M-database-changes Metadata: This PR involves database schema changes label Jun 6, 2024
@github-actions github-actions bot added the M-database-changes Metadata: This PR involves database schema changes label Jun 6, 2024
@github-actions github-actions bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Jun 6, 2024
@ShankarSinghC ShankarSinghC removed M-database-changes Metadata: This PR involves database schema changes M-api-contract-changes Metadata: This PR involves API contract changes labels Jun 6, 2024
@github-actions github-actions bot added M-database-changes Metadata: This PR involves database schema changes M-api-contract-changes Metadata: This PR involves API contract changes labels Jun 6, 2024
@github-actions github-actions bot removed M-database-changes Metadata: This PR involves database schema changes M-api-contract-changes Metadata: This PR involves API contract changes labels Jun 6, 2024
SanchithHegde
SanchithHegde reviewed Jun 7, 2024
View reviewed changes
.github/workflows/pr-convention-checks.yml Outdated Show resolved Hide resolved
.github/workflows/pr-convention-checks.yml Outdated Show resolved Hide resolved
.github/workflows/pr-convention-checks.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@ShankarSinghC ShankarSinghC

Labels
A-CI-CD Area: Continuous Integration/Deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: use git diff to add M-database-changes label for pr that contains migrations and schema changes
2 participants
@ShankarSinghC @SanchithHegde