Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project setup, documentation and pull request template #16

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nc1z
Copy link

@nc1z nc1z commented Apr 21, 2024

Description

Cleanup the repository and provided README and pull request templates.

Why is it needed?

This makes the open source contribution experience much better, and makes the repository look more professional. This is a good start to streamline contribution workflows.

Screenshot or GIFs (if applicable)

If the changes include visual modifications, include screenshots or GIFs to demonstrate the before and after effects.

Testing

Describe the testing strategy employed for this PR, including any manual or automated tests conducted. Specify the testing environment and provide clear instructions for reviewers on how to reproduce the tests, if applicable.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

Additional Notes

Include any additional information or context that may be helpful for reviewers.

Copy link

vercel bot commented Apr 21, 2024

@nc1z is attempting to deploy a commit to the joschan21's projects Team on Vercel.

A member of the Team first needs to authorize it.

@nc1z nc1z force-pushed the feature/update-project-setup branch from 709e25f to 97df5a3 Compare April 21, 2024 03:45
@nc1z nc1z changed the title Project setup, documentation and pull request templates Project setup, documentation and pull request template Apr 21, 2024
@NatanaelBorges
Copy link

I don't think adding .DS_Store to the .gitignore file may seem like a simple solution to avoid including this file in the repository. However, there are a few reasons why this may not be the best practice:

  • Collaboration: Excluding .DS_Store files from version control ensures that collaborators working on different operating systems do not inadvertently include system-specific files in the repository. This promotes collaboration by maintaining a consistent project structure among all contributors, regardless of their operating system preferences.

  • Cleanliness: Keeping the .DS_Store file out of version control helps maintain a clean and organized repository. System-specific files like .DS_Store are not relevant to the codebase. Deleting it ensures that the repository contains only files essential to the project, making it easier to navigate and manage.

In summary, while adding .DS_Store to the .gitignore file can provide a quick solution in a Git-based workflow, it is beneficial to adopt practices that address the problem more comprehensively.

@uncenter
Copy link

I don't think adding .DS_Store to the .gitignore file may seem like a simple solution to avoid including this file in the repository. However, there are a few reasons why this may not be the best practice:

  • Collaboration: Excluding .DS_Store files from version control ensures that collaborators working on different operating systems do not inadvertently include system-specific files in the repository. This promotes collaboration by maintaining a consistent project structure among all contributors, regardless of their operating system preferences.
  • Cleanliness: Keeping the .DS_Store file out of version control helps maintain a clean and organized repository. System-specific files like .DS_Store are not relevant to the codebase. Deleting it ensures that the repository contains only files essential to the project, making it easier to navigate and manage.

In summary, while adding .DS_Store to the .gitignore file can provide a quick solution in a Git-based workflow, it is beneficial to adopt practices that address the problem more comprehensively.

ChatGPT much?

@NatanaelBorges
Copy link

I don't think adding .DS_Store to the .gitignore file may seem like a simple solution to avoid including this file in the repository. However, there are a few reasons why this may not be the best practice:

  • Collaboration: Excluding .DS_Store files from version control ensures that collaborators working on different operating systems do not inadvertently include system-specific files in the repository. This promotes collaboration by maintaining a consistent project structure among all contributors, regardless of their operating system preferences.
  • Cleanliness: Keeping the .DS_Store file out of version control helps maintain a clean and organized repository. System-specific files like .DS_Store are not relevant to the codebase. Deleting it ensures that the repository contains only files essential to the project, making it easier to navigate and manage.

In summary, while adding .DS_Store to the .gitignore file can provide a quick solution in a Git-based workflow, it is beneficial to adopt practices that address the problem more comprehensively.

ChatGPT much?

Not much, but just to try to make my point of view clear, I believe this isn't the case. What would be your opinion on this PR? It's of utmost relevance to everyone, and I would genuinely appreciate your opinion as they would help me improve further.

@namtacs namtacs mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants