Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the condition within the Animal[Symbol.hasInstance] to match the purpose of the method #3682

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

katlinfall
Copy link

Description

According to the comment above the class Animal, the purpose of the Animal[Symbol.hasInstance] method is to "assume that anything with the canEat property is an animal". The condition if (obj.canEat) return true; doesn't fit the purpose mentioned, because it checks whether !!obj.canEat === true. So if we create the object with falsy canEat property value (for example: let obj = { canEat: false};), then obj instanceof Animal will return false, meaning that obj is not the instance of Animal and the condition "anything with the canEat property is an animal" is not true.
I suggest replacing the if (obj.canEat) return true; condition with if ('canEat' in obj) return true;. The in operator returns true if the specified property is in the specified object or its prototype chain. With the new condition, obj instanceof Animal will return true even if the value of the canEat property is false, which is exactly the same as saying "anything with the canEat property is an animal".
P.S. There is also a hasOwnProperty() method, which returns a boolean indicating whether this object has the specified property as its own property (as opposed to inheriting it). This method is not suitable for the implementation Animal[Symbol.hasInstance], because the condition if (obj.hasOwnProperty('canEat')) will be truthy only if the property canEat is a property of the obj itself, but not of its prototypes.

Links

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/in
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwnProperty

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Apr 10, 2024
@javascript-translate-bot javascript-translate-bot requested a review from a team April 10, 2024 22:25
@CLAassistant
Copy link

CLAassistant commented Apr 10, 2024

CLA assistant check
All committers have signed the CLA.

@smith558 smith558 self-assigned this May 5, 2024
@smith558 smith558 added the P1 High priority label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority review needed Review needed, please approve or request changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants