Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cortex process is not terminated properly #2921

Merged
merged 2 commits into from
May 18, 2024
Merged

fix: cortex process is not terminated properly #2921

merged 2 commits into from
May 18, 2024

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

  • Fixed an issue where cortex cpp is not terminated properly

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan requested review from Van-QA and hiento09 May 17, 2024 04:19
@github-actions github-actions bot added the type: bug Something isn't working label May 17, 2024
@louis-jan louis-jan force-pushed the fix/cortex-cpp-process-is-not-terminated branch from 229659c to caa7b5e Compare May 17, 2024 05:06
@louis-jan louis-jan force-pushed the fix/cortex-cpp-process-is-not-terminated branch from caa7b5e to 6fc19f6 Compare May 17, 2024 07:28
@Van-QA
Copy link
Contributor

Van-QA commented May 17, 2024

Resolve #2920

@louis-jan louis-jan merged commit e78d057 into dev May 18, 2024
17 checks passed
@louis-jan louis-jan deleted the fix/cortex-cpp-process-is-not-terminated branch May 18, 2024 07:14
@github-actions github-actions bot added this to the v.0.5.0 🍵 Bubur Ayam milestone May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiento09 hiento09 hiento09 approved these changes

@Van-QA Van-QA Awaiting requested review from Van-QA

Assignees

@louis-jan louis-jan

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v.0.5.0 🍵 Bubur Ayam
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louis-jan @Van-QA @hiento09