Feat - DRAFT - Support plain text #2827
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Tweed <RichardoC@users.noreply.github.com>
RichardoC
force-pushed
the
support-plain-text
branch
from
6d2cc7d
to
a060846
Compare
|
I've been using 28e4405 as the basis for this, but can't actually get it to work so figured I'd raise this work in progress PR to get some help |
RichardoC
changed the title
|
Also, not sure this is the right approach for adding this functionality. I'm wondering if it would be better to support a generic "upload file" and then server side decide whether it's a pdf, plain text file, or something else and then choose the right loader in extensions/assistant-extension/src/node/retrieval.ts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Known issue, doesn't actually work and fails with the following when you do make dev and attempt to upload a plain file
jan:dev: Warning: Indexing all PDF objects jan:dev: Error jan:dev: at InvalidPDFExceptionClosure (/Users/REDACTED/jan/extensions/@janhq/assistant-extension/dist/node/pdf-b2cddb6e.js:45648:36) jan:dev: at Object.<anonymous> (/Users/REDACTED/jan/extensions/@janhq/assistant-extension/dist/node/pdf-b2cddb6e.js:45651:3) jan:dev: at __w_pdfjs_require__ (/Users/REDACTED/jan/extensions/@janhq/assistant-extension/dist/node/pdf-b2cddb6e.js:45243:31) jan:dev: at Object.<anonymous> (/Users/REDACTED/jan/extensions/@janhq/assistant-extension/dist/node/pdf-b2cddb6e.js:52978:24) jan:dev: at __w_pdfjs_require__ (/Users/REDACTED/jan/extensions/@janhq/assistant-extension/dist/node/pdf-b2cddb6e.js:45243:31) jan:dev: at /Users/REDACTED/jan/extensions/@janhq/assistant-extension/dist/node/pdf-b2cddb6e.js:45286:19 jan:dev: at /Users/REDACTED/jan/extensions/@janhq/assistant-extension/dist/node/pdf-b2cddb6e.js:45289:11 jan:dev: at webpackUniversalModuleDefinition (/Users/REDACTED/jan/extensions/@janhq/assistant-extension/dist/node/pdf-b2cddb6e.js:45222:20) jan:dev: at /Users/REDACTED/jan/extensions/@janhq/assistant-extension/dist/node/pdf-b2cddb6e.js:45223:4 jan:dev: at Object.<anonymous> (/Users/REDACTED/jan/extensions/@janhq/assistant-extension/dist/node/pdf-b2cddb6e.js:63434:3) jan:dev: at Module._compile (node:internal/modules/cjs/loader:1271:14) jan:dev: at Module._extensions..js (node:internal/modules/cjs/loader:1326:10) jan:dev: at Module.load (node:internal/modules/cjs/loader:1126:32) jan:dev: at Module._load (node:internal/modules/cjs/loader:967:12) jan:dev: at l._load (node:electron/js2c/asar_bundle:2:13642) jan:dev: at Module.require (node:internal/modules/cjs/loader:1150:19) { jan:dev: message: 'Invalid PDF structure' jan:dev: }Fixes Issues
Self Checklist