-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Get-AzureADLogs.ps1 #69
Conversation
Fixed Interval field in AzureAdSignInLogs Acquisition Added the split by time feature to Get-AzureADAuditLogs, interval 12 hours (Larger dataset than SignInLogs).
FileName Issue
Added more verbose logging
Thanks for the PR, will test it soon and see if we can merge it. |
Hi, thanks again for the pull request, it looks good and hopefully fixes some of the issues. I encountered some small errors while running the code. Maybe you already fixed them in your fork, but if not, let me know and I will try to fix them before accepting the pull request. For the I had to change the following two variables troughout the script to get it working:
Instead of Is this also the case for you? Or does it work for you without the "T" and "Z" in the date? For the For the In addition, the line below seems to be out of place, causing an error due to an unexpected token '}' in the expression or statement. Write-LogFile -Message "[INFO] Acquisition complete, check the $($OutputDir) directory for your files.." -Color "Green" Another small one, need to change 1440 to 720 in the write-logfile.
|
I'll double check and compare to my local copy shortly |
Fixed Date time formats
This reverts commit ba073a9.
That should fix the issues listed above, apologies on that one |
Hi, thanks! It looks good :). I had to fix a small error with the date format for the Audit functionality.
|
Thank you 😊 |
Fixed Interval field in AzureAdSignInLogs Acquisition
Added the split by time feature to Get-AzureADAuditLogs, interval 12 hours (Larger dataset than SignInLogs).