refactor: expose system tables by default in edge/pro #25000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A shell for the `system` table provider was added to the QueryExecutorImpl which currently does not do anything, but will enable us to tie the different system table providers into it. The QueryLog was elevated from the `Database`, i.e., namespace provider, to the QueryExecutorImpl, so that it lives accross queries.
The system.queries table is now accessible, when queries are initiated in debug mode, which is not currently enabled via the HTTP API, therefore this is not yet accessible unless via the gRPC interface. The system.queries table lists all queries in the QueryLog on the QueryExecutorImpl.
hiltontj
force-pushed
the
hiltontj/system-tables-no-debug
branch
from
4d26947
to
bd46767
Compare
hiltontj
force-pushed
the
hiltontj/system-tables-no-debug
branch
from
bd46767
to
8fc3537
Compare
hiltontj
force-pushed
the
hiltontj/system-queries-table
branch
from
b9044cd
to
c4430cf
Compare
pauldix
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to follow #24992
Closes #24989. Originally, the intention of #24989 was to make the
systemtables available when adebugheader is passed in gRPC/HTTP requests, as is done in distributed, but we decided to make them available by default in monolithicinfluxdb3.