Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0.x] ISPN-15937 Protobuf metadata cache should ignore zero-capacity config… #12266

Open
wants to merge 1 commit into
base: 14.0.x
Choose a base branch
from
Open

[14.0.x] ISPN-15937 Protobuf metadata cache should ignore zero-capacity config… #12266

wants to merge 1 commit into from
+449 −234

Conversation

github-actions[bot]
Copy link

Backport: #12229

…uration

The zero capacity node now store the schemas.

Other changes include

  • Refactor ProtobufMetadataManagerInterceptor
  • Fix remove and clear bug, to remove the protofile(s) from user context
  • Fix put registering the same protofile twice in a row
  • Move internal cache names to commons

https://issues.redhat.com/browse/ISPN-15937

@pruivo pruivo added this to the 14.0.29.Final milestone Apr 20, 2024
@tristantarrant
Copy link
Member

Compilation failure:

20:59:06  14:59:06.220 [ERROR] /home/infinispan/workspace/Infinispan_PR-12266/core/src/main/java/org/infinispan/statetransfer/StateTransferManagerImpl.java:[12,45] error: cannot find symbol
20:59:06    symbol:   class CompletionStages
20:59:06    location: package org.infinispan.commons.util.concurrent
20:59:06  14:59:06.220 [ERROR] /home/infinispan/workspace/Infinispan_PR-12266/core/src/main/java/org/infinispan/globalstate/impl/GlobalConfigurationManagerImpl.java:[20,45] error: cannot find symbol
20:59:06    symbol:   class CompletionStages
20:59:06    location: package org.infinispan.commons.util.concurrent

@pruivo
ISPN-15937 Protobuf metadata cache should ignore zero-capacity config…
d3d9768 
…uration

The zero capacity node now stores the schemas.

Other changes include
* Refactor ProtobufMetadataManagerInterceptor
* Fix remove and clear bug, to remove the protofile(s) from the user context
* Fix put registering the same protofile twice in a row
* Move internal cache names to commons
@tristantarrant
Copy link
Member

testManagerRestoreParameters needs fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pruivo pruivo Awaiting requested review from pruivo

@tristantarrant tristantarrant Awaiting requested review from tristantarrant

Assignees
No one assigned
Labels
Changes Required
Projects
None yet
Milestone
14.0.29.Final
2 participants
@tristantarrant @pruivo