New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(server): new full sync return stacked assets individually #9189
Conversation
Deploying immich with Cloudflare Pages
|
@@ -710,11 +710,11 @@ export class AssetRepository implements IAssetRepository { | |||
], | |||
}) | |||
getAllForUserFullSync(options: AssetFullSyncOptions): Promise<AssetEntity[]> { | |||
const { ownerId, isArchived, withStacked, lastCreationDate, lastId, updatedUntil, limit } = options; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove with stacked from the options interface then?
Fynn, I think we need to fix the tests as well, correct? |
Yes, I'll fix them. But it would be good to know beforehand if the sync method now works for your "test" instance ;-) |
fixes the issue that stacked child assets are not returned in large list (only as children of the parent).
Also returns archived partner assets to be backwards compatible to the getAllAssets endpoint.
Needed for #8842
mobile app expects all assets to be returned regardless of their stacked status