New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mobile): ios overnight upload #8385
base: main
Are you sure you want to change the base?
Conversation
Deploying immich with Cloudflare Pages
|
Hello, thank you for the PR. I tested the PR on a physical device and saw a lot of flashing during the upload operation. RPReplay_Final1711944612.MP4After spending more time thinking about this mechanism, since it will likely be a one-time process, we can have it enabled by default when the upload process runs on the foreground page, similar to your original implementation. What do you think? |
It should still darken the screen after some time to avoid burn-in. |
13d39a7
to
6c8ac23
Compare
I still feel that preventing device sleep in one route is much better than preventing it across the app. Also, the screen switches to an all black background with only an upload button and stop backup button in the overnight screen to save battery. The flicker issue seems to be from the animatedswitcher. I've removed it for the time being. Seems to only reproduce in an iOS simulator and not on an android emulator. |
@shenlong-tanwen I did not mean to prevent sleep across the app, only when entering the backup page. Just not needing to create an additional route |
6c8ac23
to
1a6e85f
Compare
I've added a new iOS specific button called "Start Overnight Upload" which would trigger the overnight upload directly from the backup controller page |
Changes made in the PR
Screenshots