Fixes & improvements to Subtitle Chooser #4833
Open
+103
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svobs
force-pushed
the
pr-sub-chooser-improvements
branch
2 times, most recently
from
164f8da
to
424445f
Compare
svobs
force-pushed
the
pr-sub-chooser-improvements
branch
from
424445f
to
2ed938a
Compare
This commit will: • Break osd.sub_found into osd.sub_found and osd.sub_downloading, for more appropriately specific messages • In SubChooseView: fix table border bezel, increase font size slightly & set preferred width to 600 • Modify OpenSubtitles row details: add release year, remove rating, set max 2 fraction digits to fps, remove time from upload date, increase spacing to make attribute separation more clear
svobs
force-pushed
the
pr-sub-chooser-improvements
branch
from
2ed938a
to
f08cb2a
Compare
|
Squashed + rebased to fix merge errors + improved commit msg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Like #4825 but makes additional changes:
osd.sub_found, previously set to%d subtitles found. Downloading…, was not exactly appropriate as the heading for the list of subtitles to download. It looks like this is was done because it was being reused for the actual "downloading" message. So I changed the existing message to remove theDownloading…part, and added a newosd.sub_downloadingmessage whose English version isDownloading %d subtitles, and changed the "downloading" message to use this key instead.fpsattribute's displayed value.