-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing sqlalchemy operators #85
Open
JakNowy
wants to merge
8
commits into
igorbenav:main
Choose a base branch
from
JakNowy:feat/add-missing-sqlalchemy-operators
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Missing sqlalchemy operators #85
JakNowy
wants to merge
8
commits into
igorbenav:main
from
JakNowy:feat/add-missing-sqlalchemy-operators
+68
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 68 70 +2
Lines 4819 5415 +596
==========================================
+ Hits 4819 5415 +596 ☔ View full report in Codecov by Sentry. |
JakNowy
changed the title
[WIP] Missing sqlalchemy operators
Missing sqlalchemy operators
May 28, 2024
@igorbenav this is ready for review. I'm going to add some docs tomorrow. |
igorbenav
added
enhancement
New feature or request
FastCRUD Methods
Related to FastCRUD methods
labels
Jun 1, 2024
I think all that's missing are typing fixes and docs and we're good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #79 by introducing
FastCRUD._get_sqlalchemy_filter()
method and a dictonary of filter mappings inFastCRUD._SUPPORTED_FILTERS
. Adding new sqlalchemy opertors is as simple as extending the dictonary.It also solves the
or_()
operator issue:There is some mypy issue which I struggle to solve, but it looks like it's not required. The tests pass with good coverage.