Fix: Redundant Save Button #1024
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skanderloueti
suggested changes
Apr 4, 2024
Comment on lines
219
to
+220
| <Row gutter={[12, -5]}> | ||
| <Col className="gutter-row" span={5}> | ||
| <Form.Item> | ||
| <Button type="primary" htmlType="submit" icon={<PlusOutlined />} block> | ||
| {translate('Save')} | ||
| </Button> | ||
| </Form.Item> | ||
| </Col> | ||
|
|
There was a problem hiding this comment.
When you delete a Col you should review the spacing provided by the gutter property in the Row.
| @@ -191,6 +192,7 @@ export default function DataTable({ config, extra = [] }) { | |||
| onChange={filterTable} | |||
| placeholder={translate('search')} | |||
| allowClear | |||
| suffix={<SearchOutlined />} | |||
There was a problem hiding this comment.
I think this is out of the PR topic. I quote from contribution guidelines "Do not include changes that are not related to the issue at hand."
You can read the contribution guidelines here https://github.com/idurar/idurar-erp-crm/blob/master/CONTRIBUTING.md#how-to-contribute
There was a problem hiding this comment.
Yes, this actually got commited by mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the create invoice form , there exists two save buttons having the same functionality .I deleted one of the redundant save buttons.
Screenshots (if applicable)
Before:
After:
Checklist