Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore full screen while moving or closing a fullscreen window #4490

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jsecchiero
Copy link

Describe your PR, what does it fix/add?

currently windows go into tile mode after a window closes or moves to another workspace (#3093). In this PR the first window will be put in fullscreen mode keeping a consistent behavior while working on fullscreen windows

minor fix: I did add a few configurations to let Nix add symbols to the generated binary otherwise was not possible to debug

Is it ready for merging, or does it need work?

Tested on my dual monitor setup and with the single window in a nested environment and everything is working as expected

`nix build .#hyprland-debug` will now produce symbols for debug
prupose
currently windows will be changed in tile mode if a fullscreen window is
closed
currently windows will be changed in tile mode in the source workspace
if a fullscreen window is moved in another workspace
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldnt it be better to fix the root cause, window stopping being fullscreen in the first place? This can switch which window is fullscreen, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants