Groupbar aesthetic #3197

MightyPlaza · 2023-09-06T18:15:38Z

Improves / adds more customization to groupbar:

adds group and groupbar sections to free up misc
add bottom as bar position
separates border and bar colors
allows setting groupbar heigh (bar height/gradient height depending on mode)
adds internal_bar, font and background color options
fixes gradients not updating with config reload

Mostly ready now, just needs some minors fixes

example of new config:

group {
    col.border_active = rgba(bb66ffee)
    #col.border_inactive = 0xffff0000 
    #col.border_locked_active = 0xff00ffff 
    #col.border_locked_inactive = 0xff0000ff 
    #--moveintogroup_lock_check = false-- #removed due to another commit, maybe should be moved here
    #insert_after_current = true
    groupbar {
        enabled = true
        col.active = rgba(cdd6f4cc)
        col.inactive = rgb(666699)
        #col.locked_active = 0xfff00f0f 
        #col.locked_inactive = 0xff0ff00f 
        col.background = rgb(bb66ff)
        #render_titles = false 
        #scrolling = true
        max_size = 200
        titles_font_size = 8
        mode = 0 # 0 - bar, 1 - gradient 
        height = 18
        #internal_bar = false 
        font = JetBrainsMono Nerd Font Mono
        top = no
        text_color = rgb(333333)
        #unified_border = 1
    }
}

spikespaz · 2023-09-13T10:53:48Z

Cool. Haven't looked into this in-depth, but I think a rectangle that can be styled might be the simplest way to go about this?

Text font
Stroke color/gradient
Stroke weight
Fill color/gradient
Border radius
Vertical offset (box/bar)
Horizontal offset (box/bar)
Vertical offset (text)
Horizontal offset (text)
Drop shadow (same settings as tiles)

I think that should cover most styles we could conceive of.

MightyPlaza

Also there are some border damage issues, when toggling group on floating windows, for example.
damageWindow() should cover those but doesn't seem to be called at the right time
Edit: looks like storing InternalExtents as a CAnimatedVariable fixes this
fixed, not doing animations yet since that would require more control over decorations
I might just write a decoration manager someday

text boxes calculation seems to also currently be wrong, since pango absolute size isn't being used
and even after doing this, extra descent and ascent doesn't not seem to be taken into account

borders currently get anti-aliased but shadows don't seem to, which makes them look uglier now

rest should be ready

MightyPlaza · 2023-09-14T23:47:03Z

src/render/decorations/CHyprGroupBarDecoration.cpp

-            rect.y -= (*PTITLEFONTSIZE + 2 * BAR_TEXT_PAD) * 0.2 * pMonitor->scale;
-            rect.height = (*PTITLEFONTSIZE + 2 * BAR_TEXT_PAD) * pMonitor->scale;
+        if (gradBox.width > 0 && gradBox.height > 0) {
+            if (m_tGradientActive.m_iTexID == 0) // no idea why it doesn't work


when removing this, somehow the refreshGradients() function gets called, but texture doesn't exist
I haven't yet found what I'm doing wrong

MightyPlaza · 2023-09-16T20:59:46Z

@vaxerski apart from the 2 issues I still haven't found a fix for this should be ready for review
anti-aliasing rendering is clearly not an issue from here, since it's happens on main when border_size = 0, starting shadows from border just makes it more noticeable

modified: src/Compositor.cpp modified: src/config/ConfigManager.cpp modified: src/layout/DwindleLayout.cpp modified: src/layout/MasterLayout.cpp modified: src/managers/KeybindManager.cpp modified: src/managers/input/InputManager.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp modified: src/Compositor.cpp modified: src/config/ConfigManager.cpp modified: src/managers/KeybindManager.cpp modified: src/managers/input/InputManager.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp modified: src/Compositor.cpp modified: src/config/ConfigManager.cpp modified: src/managers/KeybindManager.cpp modified: src/managers/input/InputManager.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/config/ConfigManager.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp modified: src/render/decorations/CHyprGroupBarDecoration.hpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/config/ConfigManager.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/Compositor.cpp modified: src/config/ConfigManager.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp modified: src/Compositor.cpp modified: src/config/ConfigManager.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/config/ConfigManager.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp modified: src/render/decorations/CHyprGroupBarDecoration.hpp modified: src/render/decorations/IHyprWindowDecoration.cpp modified: src/render/decorations/IHyprWindowDecoration.hpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/config/ConfigManager.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/config/ConfigManager.cpp modified: src/render/Renderer.cpp modified: src/render/Texture.hpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp modified: src/render/decorations/CHyprGroupBarDecoration.hpp modified: src/render/decorations/IHyprWindowDecoration.hpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/render/decorations/CHyprGroupBarDecoration.cpp modified: src/render/decorations/IHyprWindowDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/render/decorations/CHyprGroupBarDecoration.cpp modified: src/render/decorations/CHyprGroupBarDecoration.hpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/config/ConfigManager.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/Window.cpp modified: src/Window.hpp modified: src/config/ConfigManager.cpp modified: src/render/Renderer.cpp modified: subprojects/wlroots Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/Window.cpp modified: src/Window.hpp modified: src/render/Renderer.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/render/decorations/CHyprDropShadowDecoration.cpp modified: src/render/decorations/IHyprWindowDecoration.cpp modified: src/render/decorations/IHyprWindowDecoration.hpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/Window.cpp modified: src/Window.hpp modified: src/layout/DwindleLayout.cpp modified: src/layout/MasterLayout.cpp modified: src/managers/AnimationManager.cpp modified: src/render/decorations/CHyprDropShadowDecoration.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp modified: src/render/decorations/CHyprGroupBarDecoration.hpp modified: src/render/decorations/IHyprWindowDecoration.cpp modified: src/render/decorations/IHyprWindowDecoration.hpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/config/ConfigManager.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp modified: src/render/decorations/CHyprGroupBarDecoration.hpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/render/decorations/CHyprGroupBarDecoration.cpp modified: src/render/decorations/CHyprGroupBarDecoration.hpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

MightyPlaza · 2023-10-07T23:50:47Z

internal_bar is really intended for solid bars not gradients, imo doesn't look that bad. (maybe an inside and an outside border would be better)
internal decoration is kinda hacked together, a proper solution would be to handle borders like any other decoration, and control decorations placement better.

like I said, the only remaining problems are rounding issues on boxes which might be more noticeable since I made shadows start at the end of borders, and me still not finding the cause of textures getting deleted which makes them be created on the draw() call.

vaxerski · 2023-10-08T00:01:57Z

internal decoration is kinda hacked together,

another reason to move this, if at all, to a separate mr

spikespaz · 2023-10-08T04:14:30Z

great stuff but the deco inside the border is really hideous. Rest is generally alright. We should rethink the design of groupbars in general tbh

Why don't you follow the box styling ideas I suggested and add features based on that? It's already a familiar concept to most people.

MightyPlaza · 2023-10-08T09:38:44Z

generally this MR is quite sizeable. I'd be for dropping internal decorations altogether, to me they serve no purpose.

I think vaxry is right. I'm gonna separate this into smaller MRs, which, I hope, will be much easier to handle

aacebedo · 2023-11-01T13:03:28Z

@MightyPlaza do you have the other MR ? (especially for the backgound color).

MightyPlaza · 2023-11-01T14:01:17Z

@MightyPlaza do you have the other MR ? (especially for the backgound color).

I have and will continue to separate this PR into smaller ones
To avoid merge conflicts I am creating 1 at each time
Currently still doing internal reworks, but after that will start adding the visual changes

aacebedo · 2023-11-01T14:42:06Z

@MightyPlaza do you have the other MR ? (especially for the backgound color).

I have and will continue to separate this PR into smaller ones To avoid merge conflicts I am creating 1 at each time Currently still doing internal reworks, but after that will start adding the visual changes

noted ! Thanks for the update I am going to need this

aacebedo · 2023-11-02T18:53:19Z

Another question about the font management. Do you know if the PR supports using a font with bold weight?

MightyPlaza · 2023-11-02T18:58:17Z

Another question about the font management. Do you know if the PR supports using a font with bold weight?

pretty sure 9ce1310 allows that
feel free to pr it if you want, should work without extra work

aacebedo · 2023-11-02T20:02:44Z

Another question about the font management. Do you know if the PR supports using a font with bold weight?

pretty sure 9ce1310 allows that
feel free to pr it if you want, should work without extra work

Actually, I tried a plug-in (https://github1s.com/outfoxxed/hy3) which is doing the same. The author pointed me to hyprland repo for this specific part of but they did not test the bold font support.
I tested some values but was unable to make it work.
I checked the pango spec (tried "Sans Bold" ) so I don't see why it is not working.

MightyPlaza · 2023-11-02T20:23:46Z

seems to work for me
https://docs.gtk.org/Pango/type_func.FontDescription.from_string.html
with
font = JetBrainsMono Nerd Font Mono Italic Extra-Bold

aacebedo · 2023-11-03T07:03:14Z

JetBrainsMono Nerd Font Mono Italic Extra-Bold

Thanks that's working. I had an issue in the font name I think.

RichAyotte · 2024-01-14T16:55:26Z

Can't wait for this to get merged 🤩 I've just hardcoded a few things in the meatime.

StanSvec · 2024-02-18T10:43:08Z

@MightyPlaza May I ask you for an update or ETA of this work please?

MightyPlaza marked this pull request as draft September 6, 2023 18:16

vaxerski mentioned this pull request Sep 13, 2023

Aesthetic requests for group bars #2415

Open

MightyPlaza force-pushed the groupbar-visual branch from 52bc992 to 02a34b5 Compare September 14, 2023 23:40

MightyPlaza marked this pull request as ready for review September 14, 2023 23:42

MightyPlaza commented Sep 14, 2023

View reviewed changes

MightyPlaza force-pushed the groupbar-visual branch from ca9a4de to 133d036 Compare October 7, 2023 12:09

MightyPlaza added 22 commits October 7, 2023 13:19

add bottom bar

ea1d16b

modified: src/config/ConfigManager.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp modified: src/render/decorations/CHyprGroupBarDecoration.hpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

add groupbar text font

9ce1310

modified: src/config/ConfigManager.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

add groupbar height when gradient == 0

40d16db

Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

add groupbar mode

3c16da3

modified: src/config/ConfigManager.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

groupbar start after end of rounding (breaks mouse)

0120273

modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

fix reloading locked gradients

566cfe2

modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

fix getWindowDecorationRegion with internal_border

71e9b7c

modified: src/render/decorations/CHyprGroupBarDecoration.cpp modified: src/render/decorations/IHyprWindowDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

add internal rounding

cc26620

modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

add custom getWindowDecorationRegion for groupbar

4ed0cd7

modified: src/render/decorations/CHyprGroupBarDecoration.cpp modified: src/render/decorations/CHyprGroupBarDecoration.hpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

fix var name

bc62fac

modified: src/config/ConfigManager.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

store window internal and external reserved area

5c2f22e

modified: src/Window.cpp modified: src/Window.hpp modified: src/config/ConfigManager.cpp modified: src/render/Renderer.cpp modified: subprojects/wlroots Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

replace rounding() with getRealRounding()

80d5bec

modified: src/Window.cpp modified: src/Window.hpp modified: src/render/Renderer.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

begin shadow at end of border

48641b5

modified: src/render/decorations/CHyprDropShadowDecoration.cpp modified: src/render/decorations/IHyprWindowDecoration.cpp modified: src/render/decorations/IHyprWindowDecoration.hpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

allow disabling groupbar

5457565

modified: src/config/ConfigManager.cpp modified: src/render/decorations/CHyprGroupBarDecoration.cpp modified: src/render/decorations/CHyprGroupBarDecoration.hpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

fix rounding

db555b9

modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

change var name

7aa0a88

modified: src/render/decorations/CHyprGroupBarDecoration.cpp modified: src/render/decorations/CHyprGroupBarDecoration.hpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

add external padding

85f570b

modified: src/render/decorations/CHyprGroupBarDecoration.cpp Signed-off-by: MightyPlaza <123664421+MightyPlaza@users.noreply.github.com>

MightyPlaza mentioned this pull request Oct 8, 2023

create group and groupbar config sections #3522

Merged

aacebedo mentioned this pull request Nov 2, 2023

Unable to have a bold font in title outfoxxed/hy3#40

Closed

vaxerski force-pushed the main branch 2 times, most recently from bb93090 to 3a189c2 Compare January 1, 2024 17:05

vaxerski force-pushed the main branch from 12db9ba to 094bce8 Compare April 5, 2024 18:43

vaxerski force-pushed the main branch 9 times, most recently from 7110a04 to 25aec3a Compare April 27, 2024 02:17

vaxerski force-pushed the main branch 2 times, most recently from fb471b8 to 1237732 Compare May 3, 2024 21:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Groupbar aesthetic #3197

Groupbar aesthetic #3197

MightyPlaza commented Sep 6, 2023 •

edited

spikespaz commented Sep 13, 2023 •

edited

MightyPlaza left a comment •

edited

MightyPlaza Sep 14, 2023

MightyPlaza commented Sep 16, 2023 •

edited

MightyPlaza commented Oct 7, 2023

vaxerski commented Oct 8, 2023

spikespaz commented Oct 8, 2023 •

edited

MightyPlaza commented Oct 8, 2023

aacebedo commented Nov 1, 2023

MightyPlaza commented Nov 1, 2023

aacebedo commented Nov 1, 2023

aacebedo commented Nov 2, 2023

MightyPlaza commented Nov 2, 2023

aacebedo commented Nov 2, 2023

MightyPlaza commented Nov 2, 2023

aacebedo commented Nov 3, 2023

RichAyotte commented Jan 14, 2024

StanSvec commented Feb 18, 2024

Groupbar aesthetic #3197

Are you sure you want to change the base?

Groupbar aesthetic #3197

Conversation

MightyPlaza commented Sep 6, 2023 • edited

spikespaz commented Sep 13, 2023 • edited

MightyPlaza left a comment • edited

Choose a reason for hiding this comment

MightyPlaza Sep 14, 2023

Choose a reason for hiding this comment

MightyPlaza commented Sep 16, 2023 • edited

MightyPlaza commented Oct 7, 2023

vaxerski commented Oct 8, 2023

spikespaz commented Oct 8, 2023 • edited

MightyPlaza commented Oct 8, 2023

aacebedo commented Nov 1, 2023

MightyPlaza commented Nov 1, 2023

aacebedo commented Nov 1, 2023

aacebedo commented Nov 2, 2023

MightyPlaza commented Nov 2, 2023

aacebedo commented Nov 2, 2023

MightyPlaza commented Nov 2, 2023

aacebedo commented Nov 3, 2023

RichAyotte commented Jan 14, 2024

StanSvec commented Feb 18, 2024

MightyPlaza commented Sep 6, 2023 •

edited

spikespaz commented Sep 13, 2023 •

edited

MightyPlaza left a comment •

edited

MightyPlaza commented Sep 16, 2023 •

edited

spikespaz commented Oct 8, 2023 •

edited