Added the ability to return the dictionary to the WER metric. #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the metric can return two different data types: - old variant - only value (float) - new variant - dictionary with a key containing the metric name and value (float type).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. Added the ability to return the result in the dictionary to the WER metric. I'm not sure I've done everything correctly (it's the first time I suggest changes for the bibiloteka). #516
The essence of the problem: Because the WER metric returns a value, but not a dictionary containing the name of the metric and its value, with it often have to do unnecessary conversion constructs.
This is my proposal to solve this problem while maintaining compatibility with the old code.
That is, add an additional parameter to this metric that has a default value. This parameter defines the type of the returned parameter.
I will be grateful if you can tell me how to test and what else should be done.