Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dockerfile for Ascend NPU #7956

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MengqingCao
Copy link
Contributor

What does this PR do?

Add dockerfile for Ascend NPU, based on PyTorch.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

cc @sayakpaul @yiyixuxu @DN6

@MengqingCao MengqingCao reopened this May 16, 2024
@sayakpaul
Copy link
Member

I am not opposed to having this Dockerfile but I don't think we have test cases in the library yet that would benefit from the corresponding Docker image. We only have limited support for NPUs which was introduced in #7916.

So, I am going to defer to @yiyixuxu to make a call here.

@MengqingCao
Copy link
Contributor Author

I am not opposed to having this Dockerfile but I don't think we have test cases in the library yet that would benefit from the corresponding Docker image. We only have limited support for NPUs which was introduced in #7916.

I got what you mean. A small question, are all the Dockerfiles in this repo work for UT test or CI? I thought this was for users to quickly set up their own development environment.

@sayakpaul
Copy link
Member

A small question, are all the Dockerfiles in this repo work for UT test or CI? I thought this was for users to quickly set up their own development environment.

Both.

@yiyixuxu
Copy link
Collaborator

I think we don't need this just yet? cc @DN6

@DN6
Copy link
Collaborator

DN6 commented May 21, 2024

We don't have access to NPUs in our CI, so I don't think we can add it here.

@MengqingCao
Copy link
Contributor Author

@sayakpaul @yiyixuxu @DN6 thanks for your suggestion! I think it's better to reopen this pr after the access to NPU and related UTs are ready.

@MengqingCao MengqingCao marked this pull request as draft May 25, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants