Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint tutorial: Fix YAML example #32806

Merged
merged 1 commit into from
May 17, 2024

Conversation

c0ffeeca7
Copy link
Contributor

Proposed change

Blueprint tutorial: Fix YAML example

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

- there should be no filter under entity for the target selector
- implements feedback from #32671
@home-assistant home-assistant bot added the current This PR goes into the current branch label May 16, 2024
Copy link

netlify bot commented May 16, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit af5f7e7
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6645fdbca7c5e00008927a62
😎 Deploy Preview https://deploy-preview-32806--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@frenck
Copy link
Member

frenck commented May 16, 2024

I don't think this is correct. You are re-introducing the old syntax

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out to be incorrect afterall.

Thanks for the correction 👍

../Frenck

@frenck frenck merged commit 65ad89a into current May 17, 2024
8 checks passed
@frenck frenck deleted the blueprint-tutorial-fix-yaml-example branch May 17, 2024 06:19
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial code is broken in blueprint tutorial
2 participants