Add visibility option to sections (conditional section) #20805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
May 20, 2024
| @@ -338,6 +342,7 @@ export class HaChartBase extends LitElement { | |||
| options: this._createOptions(), | |||
| plugins: this._createPlugins(), | |||
| }); | |||
| this._loading = false; | |||
There was a problem hiding this comment.
Should we put this in a finally block so an exception won't leave you in a forever loading state?
balloob
reviewed
May 20, 2024
balloob
reviewed
May 20, 2024
balloob
reviewed
May 20, 2024
| this._config = findLovelaceContainer(this._params.lovelaceConfig, [ | ||
| this._params.viewIndex, | ||
| this._params.sectionIndex, | ||
| ]) as LovelaceSectionRawConfig; |
There was a problem hiding this comment.
For another day, but I feel like we should be able to teach TS that passing an array with 2 numbers to findLovelaceContainer always returns LovelaceSectionRawConfig
balloob
reviewed
May 20, 2024
| `ui.panel.lovelace.editor.edit_section.visibility.explanation` | ||
| )} | ||
| </ha-alert> | ||
| <ha-card-conditions-editor |
balloob
reviewed
May 20, 2024
| } | ||
| this._clearMediaQueries(); | ||
| this._listeners = createConditionMediaQueriesListeners( |
There was a problem hiding this comment.
btw is create the right word? attach is more appropriate maybe?
piitaya
force-pushed
the
section-visibility
branch
from
e3d7b5c
to
3021768
Compare
frenck
approved these changes
May 21, 2024
13 tasks
c0ffeeca7
added a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Jun 4, 2024
- update views page to include the background tab - update sections view to include background and conditions - move steps on adding cards and section and on deleting a section into separate procedures - related to home-assistant/frontend#20708 and home-assistant/frontend#20805
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds the possibility to hide/show sections based on certains conditions. For example, you may want to only display a section on mobile, where you're at home and when the kitchen lights are on.
It uses the same conditions as condition cards (https://www.home-assistant.io/dashboards/conditional/#conditions-options) which are :
It's not a new section but a new
visibilityoptions in the section config.Example of UI configuration
Example of YAML configuration
Demo time 馃帀
demo-section-visibility.mp4
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: