-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSS variables to ha-toast #20804
base: dev
Are you sure you want to change the base?
Conversation
Added two variables for styling ha-toast
Changed from material design variable to css style
added import
Added css variables
Whoepsie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up. 👍 You should add the css class to the ha-toast component instead of the notification-manager.
FYI: CI is also failing right now as you closed the class too early.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Proposed change
Added two variables for styling ha-toast. One for the background and one for the text color. Unfortunatly, I'm not on a good enough laptop to check if code works. According to https://m2.material.io/components/snackbars/web#javascript-api these variables should work.
Type of change
Example configuration
theme.yaml:
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: