Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app-theme-color not following header color #20758

Merged
merged 3 commits into from
May 22, 2024

Conversation

Nezz
Copy link
Contributor

@Nezz Nezz commented May 8, 2024

Proposed change

Fix app-theme-color not following header color when the default theme is used in dark mode with the default primary color. The bug was released in 2024.5 and was introduced in #20558.

It was incorrectly fixed in #20671, only covering cases where users override the primary color. With this proper fix, that workaround is no longer needed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

  1. Default theme, dark mode, default primary color
  2. Default theme, dark mode, manually set primary color

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@Nezz Nezz changed the title Fix/app theme color dark default Fix app-theme-color not following header color May 8, 2024
@piitaya
Copy link
Member

piitaya commented May 22, 2024

Thank you !

@piitaya piitaya merged commit 19f94ff into home-assistant:dev May 22, 2024
13 checks passed
@Nezz Nezz deleted the fix/AppThemeColorDarkDefault branch May 22, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser Tab colour does not match Theme colour
2 participants