"add support for vllm api stop parameter" #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyouga
reviewed
May 6, 2024
| @@ -46,7 +46,10 @@ class GeneratingArguments: | |||
| default=1.0, | |||
| metadata={"help": "Exponential penalty to the length that is used with beam-based generation."}, | |||
| ) | |||
|
|
|||
| stop: Union[Optional[str], List[str]] = field( | |||
There was a problem hiding this comment.
The arguments in GeneratingArguments should also be contained in the https://huggingface.co/docs/transformers/v4.40.2/en/main_classes/text_generation#transformers.GenerationConfig, but it is not now, we will delete it
src/llmtuner/chat/vllm_engine.py
Outdated
| @@ -105,6 +106,7 @@ async def _generate( | |||
| top_k=top_k or generating_args["top_k"], | |||
| num_return_sequences=num_return_sequences or 1, | |||
| repetition_penalty=repetition_penalty or generating_args["repetition_penalty"], | |||
| stop=stop or generating_args["stop"] | |||
There was a problem hiding this comment.
we don't need to insert it into generating_args
hiyouga
approved these changes
May 6, 2024
|
Some necessary changes have been made and this pr can be merged |
hiyouga
added
solved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3114
Before submitting