Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added units for atmospheric chemistry applications #1392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vinodkatmos
Copy link

Added volume mixing ratio units like ppt, ppm and ppb

  • Closes # (insert issue number)
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

Added volume mixing ratio units like ppt, ppm and ppb
@cpascual
Copy link
Contributor

I think this should be evaluated taking into account the discussion in #1277 .
Specifically, the doubts regarding the ambiguous ones such as ppb

@cpascual
Copy link
Contributor

Also, this PR proposes adding ppmV = 1e-6 mole / mole = ppm. I would not associate ppm (or ppb and ppt, etc) specifically to Volume ratios, since it can be used in so many other contexts (mass, particles,...). Instead, I would prefer an approach like that in #1277 where they are simply considered unitless dimensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants