Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single z-index for tooltips and popups #5195

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Single z-index for tooltips and popups #5195

wants to merge 3 commits into from

Conversation

ThetaDR
Copy link
Member

@ThetaDR ThetaDR commented Apr 4, 2024

Override zIndex for cases the popup opens from tooltip (ex.: comments)

image

@ThetaDR ThetaDR requested a review from BykhovDenis April 4, 2024 15:18
@ThetaDR ThetaDR marked this pull request as draft April 4, 2024 15:49
haiodo
haiodo previously approved these changes Apr 5, 2024
@aonnikov
Copy link
Member

aonnikov commented Apr 5, 2024

to be honest, I don't like this approach. It is good as a temporary solution, but eventually overrides will produce more mess because we will have to manually manage all z-indexes.

Ideally, we need to get rid of library that is used in editor for popups and replace them with our popups. Alternatively, we can expose z-index counter or methods for accessing it and use it in text editor.

Copy link
Member

haiodo commented Apr 5, 2024

I think we need unified z-layer order allocator between popups and tooltips.

Copy link
Member

haiodo commented Apr 5, 2024

Or unify them under one place.

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR changed the title Allow overriding of zIndex for popups Single z-index for tooltips and popups Apr 10, 2024
@ThetaDR ThetaDR marked this pull request as ready for review April 10, 2024 06:53
@ThetaDR ThetaDR requested a review from haiodo April 10, 2024 06:53
@ThetaDR ThetaDR marked this pull request as draft April 10, 2024 07:53
@ThetaDR
Copy link
Member Author

ThetaDR commented Apr 10, 2024

Discussed with @aonnikov, going to use svelte use directive for it, it should make it more stable so it should prevent some of the bugs compared to this approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants