Remove netdaemon support

[emontnemery]

Remove deprecated netdaemon support

[emontnemery]

HacsConfiguration.update_from_dict needs to be adjusted to ignore saved netdaemon configuration

Edit:
Fixed + test added

[emontnemery]

@coderabbitai review

[coderabbitai]

Actions Performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Walkthrough

The recent changes primarily focus on the removal of NetDaemon-related functionality from the HACS (Home Assistant Community Store) codebase. This includes eliminating NetDaemon categories, configuration options, repository handling, and associated test cases. The updates streamline the code by removing deprecated NetDaemon components, simplifying the configuration, and ensuring existing features are unaffected.

Changes

Files	Change Summary
action/action.py	Removed "netdaemon" from the CATEGORIES list.
custom_components/hacs/base.py	Removed netdaemon_path and netdaemon attributes from HacsConfiguration, skipped "netdaemon" in update_from_dict, and removed netdaemon logic in set_active_categories.
custom_components/hacs/config_flow.py	Removed NETDAEMON option from configuration flow.
custom_components/hacs/diagnostics.py	Removed netdaemon from async_get_config_entry_diagnostics.
custom_components/hacs/enums.py	Removed NETDAEMON from HacsCategory enum.
custom_components/hacs/repositories/__init__.py	Removed HacsNetdaemonRepository from the list of repositories.
custom_components/hacs/repositories/base.py	Removed BackupNetDaemon import and logic, adjusted category check logic.
custom_components/hacs/translations/en.json	Removed netdaemon key and description.
custom_components/hacs/utils/backup.py	Added debug log to cleanup method, removed BackupNetDaemon class and methods.
custom_components/hacs/utils/configuration_schema.py	Removed NETDAEMON option from hacs_config_option_schema function.
custom_components/hacs/utils/path.py	Removed netdaemon_path parameter and usage.
custom_components/hacs/utils/validate.py	Removed V2_NETDAEMON_DATA_JSON_SCHEMA from _V2_REPO_SCHEMAS.
tests/conftest.py	Removed HacsNetdaemonRepository declaration, repository_netdaemon fixture, and netdaemon option from setup_integration.
tests/hacsbase/test_backup.py	Removed BackupNetDaemon class import and related test functions.
tests/hacsbase/test_configuration.py	Removed netdaemon assertions, added test_ignore_netdaemon function.
tests/helpers/download/test_gather_files_to_download.py	Removed test_gather_netdaemon_files_base function.
tests/output/proxy_calls.json	Removed API calls related to netdaemon repositories.
tests/snapshots/diagnostics/base.json	Removed netdaemon option, updated experimental flag.
tests/snapshots/diagnostics/exception.json	Removed netdaemon option, kept experimental flag.
tests/test_config_flow.py	Removed netdaemon option from test_options_flow function.
tests/utils/test_validate.py	Removed netdaemon string from test_critical_repo_data_json_schema_bad_data function.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (7)

custom_components/hacs/repositories/__init__.py (1)

Line range hint 1-14: Potential oversight: HacsNetdaemonRepository removal not reflected.

It appears that the removal of HacsNetdaemonRepository is not reflected in this file. Please verify if this is an oversight and if the repository should indeed be removed from the REPOSITORY_CLASSES dictionary.

custom_components/hacs/utils/path.py (1)

Line range hint 9-9: Remove unused import.

- from ..base import HacsConfiguration

The import HacsConfiguration is unused and should be removed to clean up the code.

custom_components/hacs/enums.py (1)

Line range hint 1-60: Potential oversight: NETDAEMON enum removal not reflected.

It appears that the removal of the NETDAEMON enum is not reflected in this file. Please verify if this is an oversight and if the enum should indeed be removed.

tests/test_config_flow.py (1)

Line range hint 13-13: The import of HacsBase is unused and should be removed to clean up the code.

- from custom_components.hacs.base import HacsBase

tests/conftest.py (1)

Line range hint 5-5: The import of OrderedDict is unused and should be removed to clean up the code.

- from collections import OrderedDict

tests/utils/test_validate.py (1)

Line range hint 17-17: Correct the typographical error in the function name.

- def test_hacs_manufest_json_schema():
+ def test_hacs_manifest_json_schema():

tests/output/proxy_calls.json (1)

[!TIP]
Codebase Verification

The search results indicate that there are still multiple references to appdaemon in the tests/output/proxy_calls.json file. This suggests that the removal of netdaemon support might not be fully complete, as appdaemon-related entries are still present.

• Lines referencing appdaemon in various test cases and API calls need to be reviewed and potentially removed or updated to align with the PR's objective of removing netdaemon support.

Locations in the codebase that need attention:

• tests/helpers/download/test_gather_files_to_download.py
• tests/repositories/test_download_repository.py
• tests/repositories/test_remove_repository.py
• tests/repositories/test_update_repository.py
• tests/scripts/data/test_generate_category_data.py
• tests/test_data_client.py
• tests/test_update.py

Analysis chain

Line range hint 1-1: Ensure removal of all netdaemon-related entries.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify that no netdaemon-related entries exist in the proxy_calls.json file.

# Test: Search for 'netdaemon' in the file. Expect: No occurrences.
rg --type json 'netdaemon' tests/output/proxy_calls.json

Length of output: 56

---

---

Script:

#!/bin/bash
# Description: Verify that no netdaemon-related entries exist in the proxy_calls.json file by searching for additional potential keywords.

# Test: Search for 'netdaemon', 'NetDaemon', 'netd', and 'daemon' in the file. Expect: No occurrences.
rg --type json 'netdaemon|NetDaemon|netd|daemon' tests/output/proxy_calls.json

Length of output: 7001