Mmajcica i http client #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed IOperatingSystem to IOperatingSystemInfo and IOperatingSystemFacade to IOperatingSystem. IOperatingSystemFacade is used way more than info about the OS and should have the easier to discover name.
I'm surprised I hadn't already implemented more!
Add simple abstraction for OpenFileDialog on IDialogFacade
Add ShowMessage methods to IDialogFacade and as extensions
Installed NuGet package xunit.runner.visualstudio
Update FAKE.Core Remove download of FAKE.Core in build.cmd. Binaries were both being checked in and downloaded on each script run so I opted for leaving them checked in. Update build script to use xUnit2Helper
Add Package build task to build script Add nuspec file Update readme and license Ignore package output directory
This is inspired by a bug found in GitHub Desktop for Windows.
Make the code correct.
`GetVersionEx` is a deprecated API. Also, `OperatingSystemInfo` should match the contract of `System.OperatingSystem` which does not have `Name` and `Edition` properties. We'll keep those out of Rothko for the time being.
Based on the API that we wrap.
Not sure why these were not implemented.
- add required space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.