Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubernetes exec via WebSockets/SPDY section to the test plan. #41683

Merged
merged 2 commits into from
May 17, 2024

Conversation

AntonAM
Copy link
Contributor

@AntonAM AntonAM commented May 17, 2024

This PR adds Kubernetes exec via WebSockets/SPDY section to the test plan.

@AntonAM AntonAM requested a review from tigrato May 17, 2024 05:00
@AntonAM AntonAM force-pushed the anton/testplan-add-kube-websockets branch from f57453b to 8e95647 Compare May 17, 2024 05:01
@AntonAM AntonAM force-pushed the anton/testplan-add-kube-websockets branch from 8e95647 to d6a4df5 Compare May 17, 2024 05:04
@AntonAM AntonAM marked this pull request as ready for review May 17, 2024 05:04
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@AntonAM AntonAM added kubernetes-access test-plan A list of tasks required to ship a successful product release. labels May 17, 2024
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@AntonAM AntonAM added the no-changelog Indicates that a PR does not require a changelog entry label May 17, 2024

### Kubernetes exec via WebSockets/SPDY

To control usage of websockets on kubectl side environment variable `KUBECTL_REMOTE_COMMAND_WEBSOCKETS` can be used:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include test for v4 websocket protocol used by other go clients

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've returned previous check: 2a1d36f

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from r0mant May 17, 2024 09:09
@AntonAM AntonAM added this pull request to the merge queue May 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 17, 2024
@AntonAM AntonAM added this pull request to the merge queue May 17, 2024
Merged via the queue into master with commit 7510f63 May 17, 2024
37 checks passed
@AntonAM AntonAM deleted the anton/testplan-add-kube-websockets branch May 17, 2024 16:58
justinas pushed a commit that referenced this pull request May 20, 2024
…1683)

* Add Kubernetes exec via WebSockets/SPDY section.

* Return javascript client websocket exec check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kubernetes-access no-changelog Indicates that a PR does not require a changelog entry size/sm test-plan A list of tasks required to ship a successful product release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants