Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth device deletion wizard #41677

Merged
merged 5 commits into from
May 22, 2024
Merged

Auth device deletion wizard #41677

merged 5 commits into from
May 22, 2024

Conversation

bl-nero
Copy link
Contributor

@bl-nero bl-nero commented May 17, 2024

This change replaces the old verification and device deletion dialogs on the account settings page.

Figma: https://www.figma.com/design/8DQZl1mYUPLgvKgmA6zPOM/In-Progress-Work?node-id=7085-45338&m=dev

Deviations from design:

  • The design didn't take the verification step into consideration, I had to get creative and make it consistent with the existing patterns.

Demo: https://us02web.zoom.us/clips/share/YOlFNDEJocRuuldA-gXOmZYHvuVL74i7a-9VEdEnCgyYXCqAifTUfUWFiV-3n8kiPc-uAIKiWcp8LD235t4VxMum.0AtdxTnxTZX3Jg0z

Closes #37622

@bl-nero bl-nero added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 labels May 17, 2024
@github-actions github-actions bot requested review from avatus and gzdunek May 17, 2024 00:16
@bl-nero
Copy link
Contributor Author

bl-nero commented May 17, 2024

Note to the reviewers: I did some basic manual testing, but I still need to give it a thorough beating. I'll do it once I get some sleep; stay tuned.

@bl-nero
Copy link
Contributor Author

bl-nero commented May 17, 2024

How embarassing, I ran into an ugly conflict with my own code and had to do a lot of post-merge fixes.

@bl-nero
Copy link
Contributor Author

bl-nero commented May 17, 2024

Tested cases:

  • Adding methods:
    • Adding a passkey
    • Adding an authenticator app, MFA key verification
    • Adding an MFA key, auth app verification
    • Adding an auth method, having only a WebAuthn key
    • Adding an auth method, having only an authenticator app
    • Adding an auth method, having no relevant verification method set up
  • Deleting methods:
    • Deleting a passkey
    • Deleting the last passkey
    • Deleting an MFA key, MFA verification
    • Deleting an authenticator app, auth app verification
    • Deleting the last MFA method, no passkey
    • Deleting an auth method, having only a WebAuthn key
    • Deleting an auth method, having only an authenticator app

@bl-nero bl-nero requested a review from gzdunek May 20, 2024 15:02
@bl-nero bl-nero added this pull request to the merge queue May 22, 2024
Merged via the queue into master with commit 7c41910 May 22, 2024
37 checks passed
@bl-nero bl-nero deleted the bl-nero/remove-auth-method branch May 22, 2024 07:03
@public-teleport-github-review-bot

@bl-nero See the table below for backport results.

Branch Result
branch/v15 Failed

bl-nero added a commit that referenced this pull request May 22, 2024
* Auth device deletion wizard

* Post-merge fixes

* Review
github-merge-queue bot pushed a commit that referenced this pull request May 23, 2024
* Auth device deletion wizard

* Post-merge fixes

* Review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v15 no-changelog Indicates that a PR does not require a changelog entry size/md ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved passkey management
3 participants