-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth device deletion wizard #41677
Merged
Merged
Auth device deletion wizard #41677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bl-nero
added
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v15
labels
May 17, 2024
Note to the reviewers: I did some basic manual testing, but I still need to give it a thorough beating. I'll do it once I get some sleep; stay tuned. |
How embarassing, I ran into an ugly conflict with my own code and had to do a lot of post-merge fixes. |
Tested cases:
|
gzdunek
reviewed
May 20, 2024
web/packages/teleport/src/Account/ManageDevices/wizards/DeleteAuthDeviceWizard.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Account/ManageDevices/wizards/ReauthenticateStep.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Account/ManageDevices/wizards/DeleteAuthDeviceWizard.tsx
Outdated
Show resolved
Hide resolved
gzdunek
approved these changes
May 21, 2024
avatus
approved these changes
May 21, 2024
bl-nero
added a commit
that referenced
this pull request
May 22, 2024
* Auth device deletion wizard * Post-merge fixes * Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the old verification and device deletion dialogs on the account settings page.
Figma: https://www.figma.com/design/8DQZl1mYUPLgvKgmA6zPOM/In-Progress-Work?node-id=7085-45338&m=dev
Deviations from design:
Demo: https://us02web.zoom.us/clips/share/YOlFNDEJocRuuldA-gXOmZYHvuVL74i7a-9VEdEnCgyYXCqAifTUfUWFiV-3n8kiPc-uAIKiWcp8LD235t4VxMum.0AtdxTnxTZX3Jg0z
Closes #37622