Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for GCP label/tag imports #41671

Merged
merged 1 commit into from
May 23, 2024
Merged

Add docs for GCP label/tag imports #41671

merged 1 commit into from
May 23, 2024

Conversation

atburke
Copy link
Contributor

@atburke atburke commented May 16, 2024

This change adds docs and updates the testplan for automatic GCP label/tag imports (#41246).

@atburke atburke added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 labels May 16, 2024
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-5oq2p0evk-goteleport.vercel.app/docs/ver/preview

ptgott
ptgott reviewed May 16, 2024
View reviewed changes
docs/pages/management/guides.mdx Outdated Show resolved Hide resolved
docs/pages/management/guides/gcp-tags.mdx Outdated Show resolved Hide resolved
docs/pages/management/guides/gcp-tags.mdx Outdated Show resolved Hide resolved
docs/pages/management/guides/gcp-tags.mdx Outdated Show resolved Hide resolved
docs/pages/management/guides/gcp-tags.mdx Outdated Show resolved Hide resolved
docs/pages/management/guides/gcp-tags.mdx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-5y89t2n0q-goteleport.vercel.app/docs/ver/preview

ptgott
ptgott approved these changes May 17, 2024
View reviewed changes
docs/pages/management/guides/gcp-tags.mdx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-j9f7olp1f-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-e5w39qox8-goteleport.vercel.app/docs/ver/preview

zmb3
zmb3 reviewed May 21, 2024
View reviewed changes
docs/config.json Show resolved Hide resolved
docs/pages/management/guides/gcp-tags.mdx Outdated Show resolved Hide resolved
docs/pages/management/guides/gcp-tags.mdx Outdated
---

When running on an Google Compute Engine instance, Teleport will automatically detect and import GCP labels and tags as
Teleport labels for SSH nodes, applications, databases, and Kubernetes clusters. Both tags and labels imported
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd that we implemented this for everything but desktops - any particular reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might have been because the imported labels would apply to the desktop service itself and not the windows desktops it manages, but I'm not sure. It would be easy to add if we wanted to.

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-maaav38va-goteleport.vercel.app/docs/ver/preview

@atburke
Copy link
Contributor Author

atburke commented May 23, 2024

Friendly ping @zmb3

zmb3
zmb3 approved these changes May 23, 2024
View reviewed changes
docs/pages/management/guides/gcp-tags.mdx Outdated
the GCP API and adds them as labels. The process will update the tags every hour,
so newly created or deleted tags will be reflected in the labels.

If the label `TeleportHostname` (case-sensitive) is present, its value will override the node's hostname.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This applies to tag or label? Right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just GCP labels. GCP tags are generally meant to be shared by multiple resources, and we don't want to share hostnames between nodes.

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-mu588xb4t-goteleport.vercel.app/docs/ver/preview

@atburke atburke enabled auto-merge May 23, 2024 23:33
@atburke atburke added this pull request to the merge queue May 23, 2024
Merged via the queue into master with commit a0a892d May 23, 2024
38 checks passed
@atburke atburke deleted the atburke/gcp-labels-docs branch May 23, 2024 23:47
@public-teleport-github-review-bot
Copy link

@atburke See the table below for backport results.

Branch Result
branch/v15 Create PR

@atburke atburke mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoandredinis marcoandredinis marcoandredinis approved these changes

@zmb3 zmb3 zmb3 approved these changes

@ptgott ptgott ptgott approved these changes

Assignees
No one assigned
Labels
backport/branch/v15 documentation no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@atburke @marcoandredinis @zmb3 @ptgott