-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ha-autoscale-cluster: Enable proxy protocol to allow the use of IP pinning #41668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webvictim
added
terraform-deployment-examples
Issues relating to Terraform deployment examples under examples/aws/terraform
terraform
Legacy Terraform label
labels
May 16, 2024
stevenGravy
approved these changes
May 17, 2024
hugoShaka
approved these changes
May 29, 2024
marcoandredinis
approved these changes
May 29, 2024
public-teleport-github-review-bot
bot
removed request for
klizhentas,
r0mant,
AntonAM and
zmb3
May 29, 2024 14:05
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 29, 2024
@webvictim See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v16
size/md
terraform
Legacy Terraform label
terraform-deployment-examples
Issues relating to Terraform deployment examples under examples/aws/terraform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Enabled the use of proxy protocol v2 for the
ha-autoscale-cluster
Terraform deployment example, allowing clusters deployed with this code to make use of IP pinning where needed.Also:
connect.sh
script more reliable by only targetting instances inrunning
stateFixes #34284
Test matrix:
use_acm
use_tls_routing
on
on
on
on
on
on
proxy_protocol
does not need to be set toon
when an ALB is used, asproxy_service.trust_x_forwarded_for
is set totrue
in these situations and the client IP is derived from theX-Forwarded-For
header.The
starter-cluster
deployment only deploys an ALB when ACM is enabled, so remains unchanged.