Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new mobile devices #1329

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

MatheusLemes5
Copy link

@MatheusLemes5 MatheusLemes5 commented May 10, 2024

What?

In this PR, new Android and iOS devices have been introduced

Why?

To be able to emulate more current devices.

Checklist

  • add new ios devices
  • add new android devices

Related PR(s)/Issue(s)

#123

@CLAassistant
Copy link

CLAassistant commented May 10, 2024

CLA assistant check
All committers have signed the CLA.

@MatheusLemes5 MatheusLemes5 changed the title Patch-1 Add new mobile devices May 10, 2024
@MatheusLemes5 MatheusLemes5 marked this pull request as draft May 13, 2024 16:28
@MatheusLemes5 MatheusLemes5 marked this pull request as ready for review May 13, 2024 16:29
@MatheusLemes5
Copy link
Author

@ankur22 @inancgumus Do you think this implementation of adding new devices makes sense? I added more devices to be able to conduct tests and extract Core Web Vitals metrics from more current devices.

@inancgumus
Copy link
Member

Hi @MatheusLemes5, thanks for your contribution. The review process would be easier if you could provide a table (or anything like that) to compare for us to see whether the device definitions are accurate. Thanks.

@MatheusLemes5 MatheusLemes5 marked this pull request as draft May 14, 2024 15:21
…DevTools and add only the ones that are on the list.
@MatheusLemes5 MatheusLemes5 marked this pull request as ready for review May 14, 2024 17:25
@MatheusLemes5
Copy link
Author

@inancgumus @ankur22
First, I generated the user agents using AI. Now, I have made changes to include only the user agents that are listed in Chrome DevTools, ensuring greater accuracy. The user agents can be found in the requests made by the page after emulating the device.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants