Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misc issue related to Declarative DSL models #29198

Merged
merged 4 commits into from
May 17, 2024

Conversation

jbartok
Copy link
Member

@jbartok jbartok commented May 17, 2024

Context

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@jbartok jbartok added this to the 8.9 RC1 milestone May 17, 2024
@jbartok jbartok self-assigned this May 17, 2024
@jbartok jbartok marked this pull request as ready for review May 17, 2024 10:01
@jbartok jbartok requested review from a team as code owners May 17, 2024 10:01
@jbartok
Copy link
Member Author

jbartok commented May 17, 2024

@bot-gradle test this

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@jbartok jbartok added this pull request to the merge queue May 17, 2024
Merged via the queue into master with commit 6c41bce May 17, 2024
57 checks passed
@jbartok jbartok deleted the jb/declarative-dsl/fix-misc-issue-related-to-models branch May 17, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants