Remove unnecessary classloader optimization #29186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bot-gradle test APT please. |
|
I've triggered the following builds for you. Click here to see all build failures. |
This is in the context of eliminating manual lists of JARs in the source code that are hard to maintain. This optimization does not seem to move the needle on our performance tests.
lptr
force-pushed
the
lptr/workers/do-not-sort-classpath
branch
from
f90e8f5
to
1a12c65
Compare
lptr
changed the title
lptr
changed the title
|
@bot-gradle test QFL please. |
|
I've triggered the following builds for you. Click here to see all build failures. |
jvandort
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in the context of eliminating manual lists of modules in the source code that are hard to maintain.
This optimization does not seem to move the needle on our performance tests.