Inroduce service-provider module
#29185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lptr
approved these changes
May 16, 2024
Comment on lines
8
to
10
| api(project(":base-services")) | ||
| api(project(":core")) | ||
| api(project(":core-api")) | ||
| api(project(":service-provider")) |
There was a problem hiding this comment.
👏 That's what we want! Now let's get rid of that :core dependency too :D
| description = "An API for providing internal services for Gradle modules" | ||
|
|
||
| dependencies { | ||
| api(projects.javaLanguageExtensions) |
There was a problem hiding this comment.
❓ How come we don't need libs.inject?
There was a problem hiding this comment.
It's not required by the classes currently moved into this new module
| @@ -13,7 +13,6 @@ errorprone { | |||
| } | |||
|
|
|||
| dependencies { | |||
| api(project(":base-services")) | |||
alllex
force-pushed
the
alllex-lptr/qa/extract-service-registry
branch
from
9c4578f
to
206cc9e
Compare
|
@bot-gradle test without pts |
|
I've triggered the following builds with parameters: |
|
@bot-gradle test without pts |
|
I've triggered the following builds with parameters: |
alllex
commented
May 17, 2024
Comment on lines
+1
to
+5
| plugins { | ||
| id("gradlebuild.distribution.implementation-java") | ||
| } | ||
|
|
||
| description = "An API for providing internal services for Gradle modules" |
There was a problem hiding this comment.
ℹ️ Adding this new project is the main change
alllex
added
the
re:platformization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No code changes, only moves some classes into a new module.
Adds a new module that is home to the classes that allows other modules to register internal Gradle services.
This includes classes like
ServiceRegistrationandPluginServiceRegistry.The
Scopeinterfaces should later be moved here as well, because they participate in the service declaration.