Add notes about testing Gradle 8.8 builds with TestKit using older Gradle versions #29184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asodja
force-pushed
the
asodja/test-kit-notes
branch
from
95b9ee7
to
a31c367
Compare
asodja
force-pushed
the
asodja/test-kit-notes
branch
from
a31c367
to
873b516
Compare
cobexer
approved these changes
May 16, 2024
ljacomet
requested changes
May 16, 2024
| @@ -510,6 +510,12 @@ This is currently used by the [JVM test suite plugin](userguide/jvm_test_suite_p | |||
|
|
|||
| See the [user manual](userguide/implementing_gradle_plugins_binary.html#custom_dependencies_blocks) to learn more about using this incubating feature. | |||
|
|
|||
| #### Testing Gradle 8.8 builds with TestKit using older Gradle version | |||
There was a problem hiding this comment.
❌ We should not mention this in release notes since that's a potential breaking change. It belongs to the upgrade guide.
| This happens because Gradle 8.7 and earlier versions set `org.gradle.native=false` for a test process. | ||
| While previous versions ignored that flag, Gradle 8.8 correctly reads `org.gradle.native` flag, and thus disables native services. | ||
|
|
||
| To fix this issue, you should use Gradle 8.8 to run the tests. |
There was a problem hiding this comment.
❓ Is that really the only option? In #29000 you list more options. IMO we should document them all here.
lkasso
reviewed
May 17, 2024
| @@ -510,6 +510,12 @@ This is currently used by the [JVM test suite plugin](userguide/jvm_test_suite_p | |||
|
|
|||
| See the [user manual](userguide/implementing_gradle_plugins_binary.html#custom_dependencies_blocks) to learn more about using this incubating feature. | |||
|
|
|||
| #### Testing Gradle 8.8 builds with TestKit using older Gradle version | |||
| [[testing_gradle_8_8_build_with_test_kit]] | ||
| ==== Testing Gradle build with TestKit using older Gradle version | ||
|
|
||
| Testing a Gradle 8.8 build with TestKit, when the version of Gradle used to run the tests is lower than 8.8, could result in problems with tested build like: |
There was a problem hiding this comment.
Suggested change
| Testing a Gradle 8.8 build with TestKit, when the version of Gradle used to run the tests is lower than 8.8, could result in problems with tested build like: | |
| Testing a Gradle 8.8 build with <<test_kit.adoc#test_kit,TestKit>> when the version of Gradle used to run the tests is lower than 8.8, can result in problems such as: |
| - File system watching not working | ||
|
|
||
| This happens because Gradle 8.7 and earlier versions set `org.gradle.native=false` for a test process. | ||
| While previous versions ignored that flag, Gradle 8.8 correctly reads `org.gradle.native` flag, and thus disables native services. |
There was a problem hiding this comment.
Suggested change
| While previous versions ignored that flag, Gradle 8.8 correctly reads `org.gradle.native` flag, and thus disables native services. | |
| While previous versions ignored that flag, Gradle 8.8 correctly reads the `org.gradle.native` flag, and thus disables native services. |
|
I've reverted the behavior of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.