Add tests for lifecycle callbacks access to surrounding methods #29164
Conversation
alllex
requested review from
bamboo,
abstratt and
6hundreds
and removed request for
a team
| println("project name = " + p.name) | ||
| } | ||
|
|
||
| allprojects { |
There was a problem hiding this comment.
❓ What value are we getting from this test?
There was a problem hiding this comment.
As we discussed, this test mirrors the similar one for Groovy DSL and locks in the behavior that, in Kotlin DSL, there is no violation.
Perhaps the test needs a better name. Do you have ideas?
There was a problem hiding this comment.
It still feels a bit wasteful in compute time. I mean, this would/should be covered elsewhere by tests that use allprojects when running with isolatedProjectsIntegTest...
There was a problem hiding this comment.
I would have thought the same about the Groovy member resolution that was not caught by tests before 🙃
There was a problem hiding this comment.
I mean, we're just now adding Isolated Projects test coverage to :core (#29202) and we do see some Groovy related errors there. No harm in having some explicit test coverage I guess.
| } | ||
|
|
||
| gradle.lifecycle.beforeProject { | ||
| Helper.printInfo(project) |
| } | ||
|
|
||
| gradle.lifecycle.beforeProject { | ||
| ${owner}.printInfo(project) |
| "static" | "static " | "Helper" | ||
| } | ||
|
|
||
| @ToBeImplemented |
| // outputContains("project name = b") | ||
| } | ||
|
|
||
| @ToBeImplemented |
| println("project name = " + p.name) | ||
| } | ||
|
|
||
| allprojects { |
There was a problem hiding this comment.
It still feels a bit wasteful in compute time. I mean, this would/should be covered elsewhere by tests that use allprojects when running with isolatedProjectsIntegTest...
Test-only PR that capture the current behavior of the
gradle.lifecyclecallbacks with respect to access of functions outside of the callback lambdas.