-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configuration.md #424
base: main
Are you sure you want to change the base?
Conversation
Added missing step of enabling the consent for the intended user.
1. Configure the [OAuth consent screen](https://console.cloud.google.com/apis/credentials/consent) by setting the application name (example: _gphotos-uploader-cli_) and then click the <kbd>Save</kbd> button on the bottom. | ||
1. Configure the [OAuth consent screen](https://console.cloud.google.com/apis/credentials/consent) by | ||
- setting the application name (example: _gphotos-uploader-cli_) | ||
- click <kbd>+ ADD USERS</kbd> under "Test users", and add your email you will authenticate with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhm... This has not been needed to me. I want to understand better when this step is needed and when it's not 😓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why it would be different for us, i had assumed you had already enabled your app so you didn't think to put it in the docs. I also have Advanced Protection enabled on my google account, perhaps that requires the extra validation. I got auth errors when I tried using the CLI without this step.
No pressure to add this to the docs if you don't want, but I wanted to contribute to make the docs match the required steps (at least for a subset of users apparently). Also, thanks for sharing the project, it was super helpful for me. It let me upload 94 albums overnight from a scanned photo archive project. It would have taken me many hours of clicking and waiting otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set up gphotos-uploader-cli today and I too had to add myself as a test user.
Going back to step 4:
Configure the OAuth consent screen by setting the application name (example: gphotos-uploader-cli) and then click the Save button on the bottom.
Here for me at least, I am only able to select a User Type
of External
. If I try to select Internal
it says:
Because you’re not a Google Workspace user, you can only make your app available to external (general audience) users.
And the description of External
says:
Available to any test user with a Google Account. Your app will start in testing mode and will only be available to users you add to the list of test users. Once your app is ready to push to production, you may need to verify your app.
So for those of us who are not google workspace users (whatever that is), we get an app in testing mode
which means we have to add ourselves to the list of authorized users for the app.
I suppose then this MR could be improved by having the instructions mention this extra step will be needed for if the User Type
is External
.
Added missing step of enabling the consent for the intended user.
What issue type does this pull request address? (keep at least one, remove the others)
/kind documentation
What is this pull request for? Which issues does it resolve? (use
resolves #<issue_number>
if possible)n/a
Does this pull request has user-facing changes?
yes, in documentation
Does this pull request add new dependencies?
no
What else do we need to know?
I'm not an experienced GCP user. I added the test user scenario which worked for me, but "publish" might be the better approach, which I believe avoids a security warning on the consent page that might alarm first-time users.