Add group policy templates to aid configuring in Chrome, Edge, and Firefox on Windows #3865
+308
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Policies for all available managed storage settings, documentation from the wiki, and usage examples.
I've not been able to make the other, new settings work.
Firefox preferences appear to not work because of uBlockOrigin/uBlock-issues#2067
Make configuring via Windows registry easier. Specifically after 1 = true and 0 = false as booleans are usually stored as dwords, so could alternatively cast to boolean if typeof disableDashboard === 'number'
|
Kind of hard to do, tried to do it with Malwarebytes for my org, but it would like trying to set Advanced Driver settings, Definitely would love to make it possible |
|
I don't think this should be committed to the code base, this should be added to the wiki. Also, it does not feel right to change uBO's code base to accommodate some scenarios very specific to one OS. How more complicated would it be to configure |
6 tasks
AminKaraniDSU
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group policy administrative templates describe settings and the UI for configuring them for administrators using Group Policy on Windows computers, and to a lesser extent serve as documentation for the registry settings used. This PR adds a template, and an English language file using descriptions of settings and examples from the wiki, to configure uBlock in Chrome, Edge, and Firefox.
The folder location seemed sensible since the files would not need to be deployed with the application, more likely an admin would download them from github to import and use, so please say if there's a preferable one.
The change to storage.js to allow truth-y values for
disableDashboardis intentional - without this, it's more complicated to configuredisableDashboardvia the registry for Firefox (the other browsers don't need this), and would prevent using a simple enable/disable policy. If needed, this could be removed or moved to a separate PR.