Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asWinding, isEmpty and addReversePath to SKPath export #176

Closed
wants to merge 1 commit into from

Conversation

ErikSom
Copy link
Contributor

@ErikSom ErikSom commented May 18, 2024

Adding missing functionality to the WASM export.
I need asWinding to ensure holes are converted from evenodd to winding.
setFillType(fillType) does not alter the winding of holes.

Copy link

google-cla bot commented May 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@skia-codereview-bot
Copy link
Collaborator

This PR (HEAD: 345e454) has been imported to Gerrit for code review.

Please visit review.skia.org/854936 to see it. Please CC yourself to the Gerrit change.

Note:

  • Skia uses only Gerrit for reviews and submitting code (doc).
  • All comments are handled within Gerrit. Any comments on the GitHub PR will be ignored.
  • The PR author can continue to upload commits to the branch used by the PR in order to address feedback from Gerrit.
  • Once the code is ready to be merged, a maintainer will submit the change on Gerrit and skia-codereview-bot will close this PR.
  • Similarly, if a change is abandoned on Gerrit, the corresponding PR will be closed with a note.

@kjlubick
Copy link
Contributor

Can you add yourself to the AUTHORS file?

@skia-codereview-bot
Copy link
Collaborator

This PR is being closed because review.skia.org/854936 has been merged.

hubot pushed a commit that referenced this pull request May 24, 2024
Adding missing functionality to the WASM export.
I need asWinding to ensure holes are converted from evenodd to winding.
setFillType(fillType) does not alter the winding of holes.

This is an imported pull request from
#176

GitOrigin-RevId: e619912
Change-Id: Ie6ad394348085c1a7fbbfa2dfb14d83620f68acf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/854936
Commit-Queue: Kaylee Lubick <kjlubick@google.com>
Reviewed-by: Kaylee Lubick <kjlubick@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants