Add partial data badges #8727
Merged
Add partial data badges #8727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 59d2419 have been deleted. |
|
Size Change: +19.9 kB (+1.38%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
kuasha420
requested changes
May 21, 2024
...alytics-4/components/audience-segmentation/dashboard/AudienceTile/AudienceTilePagesMetric.js
Outdated
Show resolved
Hide resolved
...alytics-4/components/audience-segmentation/dashboard/AudienceTile/AudienceTilePagesMetric.js
Show resolved
Hide resolved
I agree, updated, thank you! |
kuasha420
requested changes
May 23, 2024
| export default function PartialDataBadge( { tooltipTitle } ) { | ||
| return ( | ||
| <span className="googlesitekit-audience-segmentation-partial-data-badge"> | ||
| <Fragment> |
There was a problem hiding this comment.
This Fragment is no longer needed after the refactor. I'll push a commit to remove this.
There was a problem hiding this comment.
Oops, looks like I mistakenly overlooked it, thank you for removing! 🦅
kuasha420
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
This PR adds the partial data badges in Audience Segmentation widget.
Deviation from IB
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist