Add support for checkpoint structured logging. #655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobbleturk
approved these changes
May 17, 2024
yangyuwei
reviewed
May 20, 2024
MaxText/checkpointing.py
Outdated
|
|
||
| if config.enable_checkpoint_standard_logger: | ||
| orbax_standard_logger = standard_logger.StandardLogger() | ||
| max_logging.log("Sucessfully set up checkpoint standard logger.") |
There was a problem hiding this comment.
What's the difference between CloudLogger and StandardLogger?
gobbleturk
approved these changes
May 20, 2024
abhinavclemson
force-pushed
the
logger-orbax
branch
2 times, most recently
from
ad751b0
to
314c332
Compare
abhinavclemson
force-pushed
the
logger-orbax
branch
from
fa6a485
to
fa92a21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds support for checkpoint structured logging in MaxText. This allows users to log checkpoint events to Cloud Logging and/or standard logging. To enable checkpoint structured logging, users can set the
enable_checkpoint_cloud_loggerandenable_checkpoint_standard_loggerflags to True.