Add docker support to maxtext base image #564
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwitten
requested changes
Mar 28, 2024
| @@ -20,6 +20,25 @@ RUN update-alternatives --install /usr/bin/python3 python3 /usr/local/bin/python | |||
| # Set environment variables for Google Cloud SDK and Python 3.10 | |||
| ENV PATH="/usr/local/google-cloud-sdk/bin:/usr/local/bin/python3.10:${PATH}" | |||
|
|
|||
| # Install dependencies for Docker | |||
| RUN apt-get update && apt-get install -y \ | |||
There was a problem hiding this comment.
I'm really not following the design here? We're download the docker image within the docker image? shouldn't we be exporting a binary from g3 for this use case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For AOT+Hybridsim integration, we need to pull Hybridsim docker image, so we need to install docker for maxtext base image (https://screenshot.googleplex.com/BD3SMwL57tP5cQY).
Tested AOT+Hybridsim e2e on a GKE node: https://screenshot.googleplex.com/5LQwBNBp4p6iyLq
This should be a combo PR of Maxtext and XPK:
#564
google/xpk#102