Megatron style TFLOPs Calculation #537
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwitten
requested changes
Mar 20, 2024
abhinavgoel95
force-pushed
the
megatron_tflops
branch
2 times, most recently
from
3980d41
to
01c78bb
Compare
added config adding support for megatron style tflops calculation adding support for megatron style tflops calculation adding support for megatron style tflops calculations
abhinavgoel95
force-pushed
the
megatron_tflops
branch
from
01c78bb
to
43f3451
Compare
|
Made the changes as requested in the meeting @rwitten |
|
cc @rwitten following up on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rwitten this is a draft.
This type of change would be specific to a few transformer models (e.g., Gemma, LLama, GPT, etc.). It wouldn't work with MoE, or some new architectures.
I was thinking that walking through the train-step and calculating the FLOPs layer-by-layer would be a very intrusive change.
What do you think?