Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fresh base image #20438

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented May 16, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@zyyw zyyw added release-note/ignore-for-release Do not include PR or Issue for release notes target/2.11.0 labels May 16, 2024
@zyyw zyyw requested a review from a team as a code owner May 16, 2024 11:39
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-2.11.0@840d408). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20438   +/-   ##
=================================================
  Coverage                  ?   66.35%           
=================================================
  Files                     ?     1042           
  Lines                     ?   113176           
  Branches                  ?     2836           
=================================================
  Hits                      ?    75096           
  Misses                    ?    34015           
  Partials                  ?     4065           
Flag Coverage Δ
unittests 66.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

@yanji09 yanji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit 3777877 into goharbor:release-2.11.0 May 16, 2024
15 checks passed
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request May 29, 2024
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes target/2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants